Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move poetry lock --check to unit tests job #245

Merged

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Mar 26, 2024

Poetry is being used for deps installation in unit tests jobs before build job, hence moving poetry lock --check to unit tests jobs.

Test run: https://github.com/splunk/splunk-add-on-for-google-workspace/pull/543

Poetry is being used for deps installation in unit tests jobs before build job, hence moving poetry lock --check to unit tests jobs.
@artemrys
Copy link
Member

artemrys commented Mar 26, 2024

I would say it is a fix or feat, you would need to add it to the release notes because you do change the functionality of the workflow.

@mkolasinski-splunk mkolasinski-splunk changed the title chore: move poetry lock --check to unit tests job fix: move poetry lock --check to unit tests job Mar 26, 2024
@mkolasinski-splunk mkolasinski-splunk merged commit 9b8154c into develop Mar 29, 2024
6 checks passed
@mkolasinski-splunk mkolasinski-splunk deleted the chore/move-poetry-lock-check-to-unit-tests-jobs branch March 29, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants